Re: [PATCH 2/3] gpio: max77620: Implement gpio_get_direction callback

From: Laxman Dewangan
Date: Tue May 31 2016 - 02:05:40 EST

On Monday 30 May 2016 08:33 PM, Linus Walleij wrote:
On Tue, May 24, 2016 at 3:13 PM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:

Implement gpio_get_direction() callback for MAX77620 GPIO.
This is useful for debugfs and the userspace ABI.

Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
#include <linux/gpio/driver.h>
+#include <linux/gpio.h>
No. This is a sign that something is wrong, no driver should include
this unless it is using GPIOs as a resource itself.
This is just to use the flag GPIOF_*

As you said below, we can use the 0 and 1, there is no need to include header.
Will post the v2 patch for this.

+ return (val & MAX77620_CNFG_GPIO_DIR_MASK) ?
Just return 0 or 1. The driver-internal API isn't smarter than that.