Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up

[Peter Zijlstra]

On Tue, May 31, 2016 at 09:11:37AM +0800, Yuyang Du wrote:
> The SD_BALANCE_WAKE is irrelevant in the contexts of these two removals,
> and in addition SD_BALANCE_WAKE is not and should not be set in any
> sched_domain flags so far.

This Changelog doesn't make any sense...

> Signed-off-by: Yuyang Du <yuyang.du@xxxxxxxxx>
> ---
>  kernel/sched/core.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 7f2cae4..e00b8ea 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6229,10 +6229,10 @@ static void set_domain_attribute(struct sched_domain *sd,
>  		request = attr->relax_domain_level;
>  	if (request < sd->level) {
>  		/* turn off idle balance on this domain */
> -		sd->flags &= ~(SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE);
> +		sd->flags &= ~(SD_BALANCE_NEWIDLE);
>  	} else {
>  		/* turn on idle balance on this domain */
> -		sd->flags |= (SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE);
> +		sd->flags |= (SD_BALANCE_NEWIDLE);
>  	}
>  }
>  
> -- 
> 1.7.9.5
>