Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher
From: Krzysztof Kozlowski
Date: Tue May 31 2016 - 05:30:42 EST
On Sun, May 29, 2016 at 9:04 AM, Chen-Yu Tsai <wens@xxxxxxxx> wrote:
> When IS_ERR_VALUE was removed from the mmc core code, it was replaced
> with a simple not-zero check. This does not work, as the value checked
> is the return value for mmc_select_bus_width, which returns the set
> bit width on success. This made eMMC modes higher than HS-DDR unusable.
> Fix this by checking for a positive return value instead.
> Fixes: 287980e49ffc ("remove lots of IS_ERR_VALUE abuses")
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>
> drivers/mmc/core/mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
Could you be so kind and pick it up as fast as possible for current
RC? Half of my boards fail (because they work on eMMC) so testing
patches before applying is limited.