Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up

[Peter Zijlstra]

On Tue, May 31, 2016 at 09:31:32AM +0800, Yuyang Du wrote:
> On Tue, May 31, 2016 at 11:21:46AM +0200, Peter Zijlstra wrote:
> > On Tue, May 31, 2016 at 09:11:37AM +0800, Yuyang Du wrote:
> > > The SD_BALANCE_WAKE is irrelevant in the contexts of these two removals,
> > > and in addition SD_BALANCE_WAKE is not and should not be set in any
> > > sched_domain flags so far.
> > 
> > This Changelog doesn't make any sense...
> 
> How? SD_BALANCE_WAKE is not in any sched_domain flags (sd->flags), even if
> it is, it is not used anywhere, no?

It is and it is. See select_task_fair_rq():

	if (tmp->flags & sd_flags)

Now, as long as WAKE_AFFINE is also set, its hard to actually get into
the find_idlest_cpu() balancing, but if you clear all that you will
still get there.