[RFC][PATCH v5 0/9] perf config: Reimplement perf_config() using perf_config_set__inter()

From: Taeung Song
Date: Tue May 31 2016 - 13:27:04 EST

Hello, :)

This patchset is to reimplement perf_config() for efficient config management.

Everytime perf_config() is called, perf_config() always read config files.
(i.e. user config '~/.perfconfig' and system config '$(sysconfdir)/perfconfig')

But we need to use 'struct perf_config_set config_set' variable
that already contains all config key-value pairs
to avoid this repetitive work in perf_config().

In other words, if new perf_config() is called,
only first time 'config_set' is initialized
collecting all configs from config files and it work with perf_config_set__iter().

If we do, 'config_set' can be reused wherever using perf_config()
and a feature of old perf_config() is the same as new perf_config()
work without the repetitive work that read the config files.

IMHO, I think this patchset is needed because not only the repetitive work
should be avoided but also in near future, it would be smooth to manage perf configs.

Most important patch of this patchset is "[PATCH v5 7/9] perf config: Reimplement
perf_config() using perf_config_set__iter()" and PATCH 1/9 ~ 6/9 are preparation for it.

If you give me any feedback, I'd apprecicated it. :)


- solve a leak when perf_config_set__init() failed (Arnaldo)
- bugfix) let perf_config() return in case of failure
- bugfix) finally free the config set after collect_config() worked
- bugfix) handle NULL pointer exception of 'set' at collect_config()

- Keep perf_config_set__delete() as it is (Arnaldo)
- Remove perf_config_set__check() (Arnaldo)
- Keep the existing code about the config set at cmd_config() (Arnaldo)

- add freeing config set after sub-command work at run_builtin() (Namhyung)
- remove needless code about the config set at cmd_config()
- add a patch about a global variable 'config_set'

- split a patch into several patches
- reimplement show_config() using new perf_config()
- modify perf_config_set__delete using global variable 'config_set'
- reset config set when only 'config' sub-commaned work
because of options for config file location

Taeung Song (9):
perf config: Let perf_config() return in case of failure
perf config: Finally free a config set after collect_config() worked
perf config: Handle an error when config set is NULL at
perf config: Use new perf_config_set__init() to initialize config set
perf config: Add global variable 'config_set'
perf config: Use zfree() instead of free() at
perf config: Reimplement perf_config() using perf_config_set__iter()
perf config: Reset the config set at only 'config' sub-command
perf config: Reimplement show_config() using perf_config()

tools/perf/builtin-config.c | 41 +++++-------
tools/perf/perf.c | 1 +
tools/perf/util/cache.h | 1 +
tools/perf/util/config.c | 156 ++++++++++++++++++++++++++++----------------
tools/perf/util/config.h | 4 +-
5 files changed, 121 insertions(+), 82 deletions(-)