Re: [PATCH] mm, oom_reaper: do not use siglock in try_oom_reaper
From: Oleg Nesterov
Date: Tue May 31 2016 - 17:25:25 EST
On 05/31, Michal Hocko wrote:
>
> @@ -636,10 +634,7 @@ void try_oom_reaper(struct task_struct *tsk)
> * If the task is exiting make sure the whole thread group
> * is exiting and cannot acces mm anymore.
> */
> - spin_lock_irq(&p->sighand->siglock);
> - exiting = signal_group_exit(p->signal);
> - spin_unlock_irq(&p->sighand->siglock);
> - if (exiting)
> + if (signal_group_exit(p->signal))
> continue;
Yes, thanks Michal. signal_group_exit() is not really right too (coredump)
but this is not that important and you are going to rework this code anyway.
Oleg.