Re: [PATCH] Documentation: Fix some grammar mistakes in sync_file.txt
From: Gustavo Padovan
Date: Tue May 31 2016 - 20:18:54 EST
2016-05-14 Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>:
> There are two sentences in the Sync File documentation where the
> english is a little off. This patch is an attempt to fix these.
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>
> ---
>
> Documentation/sync_file.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/sync_file.txt b/Documentation/sync_file.txt
> index eaf8297dbca2..e8e2ebafe5fa 100644
> --- a/Documentation/sync_file.txt
> +++ b/Documentation/sync_file.txt
> @@ -6,8 +6,8 @@
>
> This document serves as a guide for device drivers writers on what the
> sync_file API is, and how drivers can support it. Sync file is the carrier of
> -the fences(struct fence) that needs to synchronized between drivers or across
> -process boundaries.
> +the fences(struct fence) that are needed to synchronize between drivers or
> +across process boundaries.
>
> The sync_file API is meant to be used to send and receive fence information
> to/from userspace. It enables userspace to do explicit fencing, where instead
> @@ -32,7 +32,7 @@ in-fences and out-fences
> Sync files can go either to or from userspace. When a sync_file is sent from
> the driver to userspace we call the fences it contains 'out-fences'. They are
> related to a buffer that the driver is processing or is going to process, so
> -the driver an create out-fence to be able to notify, through fence_signal(),
> +the driver creates an out-fence to be able to notify, through fence_signal(),
> when it has finished using (or processing) that buffer. Out-fences are fences
> that the driver creates.
Thanks, Javier!
Reviewed-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx>
Gustavo