Re: [PATCH 3/8] mwifiex: propagate mwifiex_add_card() errno code in mwifiex_sdio_probe()

From: Julian Calaby
Date: Wed Jun 01 2016 - 00:17:44 EST

Hi All,

On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas
<javier@xxxxxxxxxxxxxxx> wrote:
> There's only a check if mwifiex_add_card() returned a nonzero value, but
> the actual error code is neither stored nor propagated to the caller. So
> instead of always returning -1 (which is -EPERM and not a suitable errno
> code in this case), propagate the value returned by mwifiex_add_card().
> Patch also removes the assignment of sdio_disable_func() returned value
> since it was overwritten anyways and what matters is to know the error
> value returned by the first function that failed.
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

This looks sensible to me.

Reviewed-by: Julian Calaby <julian.calaby@xxxxxxxxx>

> ---
> drivers/net/wireless/marvell/mwifiex/sdio.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)


Julian Calaby

Email: julian.calaby@xxxxxxxxx