Re: [RFC][PATCH 5/5] arm64: dts: Add powerkey info to pmic for hi6220-hikey

[Rob Herring]

On Wed, Jun 1, 2016 at 4:27 PM, John Stultz <john.stultz@xxxxxxxxxx> wrote:
> From: Guodong Xu <guodong.xu@xxxxxxxxxx>
>
> Add powerkey entry to the HiKey dts.
>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Pawel Moll <pawel.moll@xxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>
> Cc: Kumar Gala <galak@xxxxxxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@xxxxxxxxxx>
> Cc: Wei Xu <xuwei5@xxxxxxxxxxxxx>
> Cc: Guodong Xu <guodong.xu@xxxxxxxxxx>
> Signed-off-by: Guodong Xu <guodong.xu@xxxxxxxxxx>
> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index e92a30c..c8e49a6 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -144,6 +144,13 @@
>                 #interrupt-cells = <2>;
>                 pmic-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
>
> +               powerkey:powerkey@b1{

nit: you probably don't need the label and unit-address is not needed, so just:

powerkey {

> +                       compatible = "hisilicon,hi6552-powerkey";
> +                       interrupt-parent = <&pmic>;
> +                       interrupts = <6 0>, <5 0>, <4 0>;
> +                       interrupt-names = "down", "up", "hold 4s";
> +               };
> +
>                 regulators {
>                         ldo2: LDO2 {
>                                 regulator-name = "LDO2_2V8";
> --
> 1.9.1
>