Re: [PATCH 0/2] Rework clk/vt8500 wm8650_find_pll_bits()

From: Stephen Boyd
Date: Wed Jun 01 2016 - 18:06:11 EST


On 05/31, Roman Volkov wrote:
> Ð Tue, 24 May 2016 23:07:51 +0300
> Roman Volkov <v1ron@xxxxxxx> ÐÐÑÐÑ:
>
> > From: Roman Volkov <rvolkov@xxxxxxxxx>
> >
> > Hi Arnd and others,
> >
> > This patch finally removes the warnings from GCC about possibly
> > uninitialized variables 'best_div2', 'best_div1', and 'best_mul'.
> > Also one of the functions is reworked, so that the algorithm is much
> > easier. This is to continue the work started in [1].
> >
> > This code is tested on WM8650. Also the testing app was used in
> > user-mode to check possible values and performance [2].
> >
> > [1] https://lkml.org/lkml/2016/2/1/149
> > [2] https://github.com/v1ron/vt8500-clkrange
> >
> > Thanks,
> > Roman Volkov (2):
> > clk/vt8500: Rework wm8650_find_pll_bits()
> > clk/vt8500: Fix compilation warnings
> >
> > drivers/clk/clk-vt8500.c | 81
> > +++++++++++++++++++++++------------------------- 1 file changed, 39
> > insertions(+), 42 deletions(-)
> >
>
> Hi Stephen,
>
> Do we need this change during this merge window?
>

The warning has been there for since before this merge window, so
if anything this is v4.8 material.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project