Re: [PATCH 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY

From: Frank Wang
Date: Wed Jun 01 2016 - 22:53:35 EST


Hi Heiko,

On 06/02/2016 06:17 AM, Heiko Stübner wrote:
Hi Frank,

Am Mittwoch, 1. Juni 2016, 16:09:41 schrieb Frank Wang:
You might want to add the bvalid and id interrupts for the otg phys as
well
already - would make handling legacy devicetree files easier. [= if they
get specified later, the driver would always need to also handle
devicetrees where they aren't specified].

Hmmm! you mean that I can specify these properties into documentation,
even if the driver have not handled (implemented) them in current?

The devicetree bindings are supposed to be a generic hardware-description.
And a driver then simply implements that binding. So if the interrupt is part
of the hardware it can be part of the binding, independent of the driver.

I guess it really comes down to, will you need those interrupts later in the
driver, then they should definitly be specified now, as later on you cannot
require them anymore and always need to also support devicetrees not having
them.


Got it, I have already added them in the new patches which I will hand out later.

BR.
Frank