Re: [PATCH][V2] net/ethoc: fix null dereference on error exit path

From: David Miller
Date: Thu Jun 02 2016 - 01:02:25 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Wed, 1 Jun 2016 14:16:50 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> priv is assigned to NULL however some of the early error exit paths to
> label 'free' dereference priv, causing a null pointer dereference.
>
> Move the label 'free' to just the free_netdev statement, and add a new
> exit path 'free2' for the error cases were clk_disable_unprepare needs
> calling before the final free.
>
> Fixes issue found by CoverityScan, CID#113260
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied, thanks.