Re: [PATCH 4/4] mm/zsmalloc: remove unused header cpumask.h

[Sergey Senozhatsky]

On (06/02/16 14:15), Geliang Tang wrote:
> Remove unused header cpumask.h from mm/zsmalloc.c.
> 
> Signed-off-by: Geliang Tang <geliangtang@xxxxxxxxx>
> ---
>  mm/zsmalloc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index b6d4f25..a93327e 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -57,7 +57,6 @@
>  #include <linux/slab.h>
>  #include <asm/tlbflush.h>
>  #include <asm/pgtable.h>
> -#include <linux/cpumask.h>
>  #include <linux/cpu.h>
>  #include <linux/vmalloc.h>
>  #include <linux/preempt.h>

NAK. I don't think it's "unused".

zs_register_cpu_notifier()
	for_each_online_cpu()


which is coming from include/linux/cpumask.h

#define for_each_online_cpu(cpu)   for_each_cpu((cpu), cpu_online_mask)

	-ss