Re: [PATCH -v2 00/33] implement atomic_fetch_$op
From: Vineet Gupta
Date: Thu Jun 02 2016 - 05:28:16 EST
On Tuesday 31 May 2016 03:59 PM, Peter Zijlstra wrote:
> - arc asm/atomic.h is a bit of a mess after the eznps merge, I would
> recommend a restructure or split of that file, but could not find
> the will to do it.
> - arc, metag and tile could convert to _relaxed.
Yes that was bothering me too. The split is indeed in order. However good news is
even w/o it I have decent cleanup as all the backoff retry code can now be
removed. The hardware guys did their foo and production RTL with latest h/w
release doesn't suffer from the scond livelock problem. I'd disabled the config
option for some time and now the code can be removed as well.
What's ur merge plan - are u going to rebase/respin once more so I can push those
updates to Linus for 4.7-rc2. Or you could carry those ARC patches in ur tree -
ahead of ur series. I'd much rather prefer the revert / cleanup before adding new
code which extends the back off code only to be deleted later.
What say you ?