Re: [PATCH 4.7 FIX] brcmfmac: fix lockup when removing P2P interface after event timeout

From: Kalle Valo
Date: Thu Jun 02 2016 - 05:43:07 EST


RafaÅ MiÅecki <zajec5@xxxxxxxxx> writes:

> Removing P2P interface is handled by sending a proper request to the
> firmware. On success firmware triggers an event and driver's handler
> removes a matching interface.
>
> However on event timeout we remove interface directly from the cfg80211
> callback. Current code doesn't handle this case correctly as it always
> assumes rtnl to be unlocked.
>
> Fix it by adding an extra rtnl_locked parameter to functions and calling
> unregister_netdevice when needed.
>
> Signed-off-by: RafaÅ MiÅecki <zajec5@xxxxxxxxx>

Arend, are you ok to push this to 4.7?

--
Kalle Valo