Re: [PATCH 3/8] cpufreq: powerenv: Fix memory leak
From: Michael Ellerman
Date: Thu Jun 02 2016 - 07:38:03 EST
On Thu, 2016-06-02 at 16:52 +0530, Viresh Kumar wrote:
> On 02-06-16, 21:08, Michael Ellerman wrote:
> > On Wed, 2016-06-01 at 16:04 +0530, Viresh Kumar wrote:
> > > The policy is copied (unnecessarily) and is never freed. Fix it by just
> > > getting a reference to the existing policy structure and putting it
> > > back.
> > >
> > > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> > When was it broken, always?
> > Cc: stable ?
> Its a small memory leak and its not that we will fail on something. So
> didn't bother to add those details, but in case they are required:
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.3+
> Fixes: 227942809b52 ("cpufreq: powernv: Restore cpu frequency to policy->cur on unthrottling")
OK. I can't actually see where the copy is?
But if we are leaking even a small amount of memory in a loop like that, in a
function that's run semi-regularly, then it's going to add up eventually.