Re: [PATCH v2 0/4] *** rtl8712: Replace semaphores with mutex / completions ***

From: Larry Finger
Date: Thu Jun 02 2016 - 11:15:40 EST


On 06/02/2016 02:43 AM, Arnd Bergmann wrote:
On Thursday, June 2, 2016 9:54:06 AM CEST Binoy Jayan wrote:
Hi,

These are a set of patches [v2] which removes semaphores from:

drivers/staging/rtl8712

They build correctly (individually and as a whole).
NB: I have not tested this as I do not have the following hardware:

"RealTek RTL8712U (RTL8192SU) Wireless LAN NIC driver"

Rework on comments w.r.t. PATCH v1:

- Removed wrapper functions _wait_completion, _down_sema and _enter_pwrlock
- Updated changelog to explain use of mutex_lock instead of
mutex_lock_interruptible in [PATCH v2 4/4]


All four look great now,

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>


I agree.

Tested-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>

Larry