Re: [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision

From: Fabio Estevam
Date: Thu Jun 02 2016 - 11:48:23 EST

Hi Clemens,

On Thu, Jun 2, 2016 at 9:47 AM, Clemens Gruber
<clemens.gruber@xxxxxxxxxxxx> wrote:
> Instead of checking the SGTL5000 chip revision, we should only check if
> the VDDD regulator exists and only call sgtl5000_replace_vddd_with_ldo
> if the regulator is missing.
> Otherwise, the user reads in the kernel log that the internal LDO is
> used, even though he did follow the NXP recommendation to use external
> VDDD and also specified VDDD-supply in the devicetree.
> Also remove the comment, which incorrectly states that external VDDD is
> only supported for SGTL5000 chip revisions < 0x11.
> Official NXP documentation recommends using external VDDD and not the
> internal LDO due to the SGTL5000 erratum ER1. This also applies to
> revisions >= 0x11.
> Tested on an i.MX6Q board with SGTL5000 rev 0x11 and external VDDD.

Patch looks good to me.


Sometime ago you were looking at this. What do you think about this patch?