Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo

From: Mark Brown
Date: Thu Jun 02 2016 - 12:24:30 EST


On Thu, Jun 02, 2016 at 09:04:32AM -0700, Bjorn Andersson wrote:
> On Thu 02 Jun 08:50 PDT 2016, Mark Brown wrote:

> > It's more natural to use a separate set of ops, and we can optimise a
> > few things if we know the regulator is a fixed voltage one.

> In my view a fixed regulator is a thing that when you turn it on you get
> a predefined voltage, but iirc we actually need to send of a set-voltage
> request for the singly supported voltage on this ldo (which both
> implementations do today...).

> That's why I suggested Srini to do it this way, but maybe my
> interpretation of "fixed" is inaccurate?

If it only supports one voltage then shouldn't we just tell it that
voltage once at startup? Doing a call in the probe routine would be
fine, the framework doesn't need to know about that really.

Attachment: signature.asc
Description: PGP signature