Re: [RFC][PATCH 2/2] arm64: dts: hi6220: Add pl031 RTC support

[John Stultz]

On Wed, Jun 1, 2016 at 8:58 PM, Guodong Xu <guodong.xu@xxxxxxxxxx> wrote:
> On 2 June 2016 at 01:39, John Stultz <john.stultz@xxxxxxxxxx> wrote:
>> From: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
>>
>> Add pl031 rtc0 support to hi6220 dtsi
>>
>> Cc: Michael Turquette <mturquette@xxxxxxxxxxxx>
>> Cc: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
>> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
>> Cc: Pawel Moll <pawel.moll@xxxxxxx>
>> Cc: Wei Xu <xuwei5@xxxxxxxxxxxxx>
>> Cc: Guodong Xu <guodong.xu@xxxxxxxxxx>
>> Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
>> [jstultz: Forward ported and tweaked commit description]
>> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> index 189d215..1288995 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> @@ -336,6 +336,14 @@
>>                         clock-names = "timer1", "timer2", "apb_pclk";
>>                 };
>>
>> +               rtc0: rtc@170000 {
>> +                       compatible = "arm,pl031", "arm,primecell";
>> +                       reg = <0x0 0xf8003000 0x0 0x1000>;
>> +                       interrupts = <0 12 4>;
>> +                       clocks = <&ao_ctrl HI6220_RTC0_PCLK>;
>> +                       clock-names = "apb_pclk";
>> +               };
>> +
>
> Hi, John
>
> Checked from Hi6220 spec, and verified on HiKey:
>
> +               rtc1: rtc@f8004000 {
> +                       compatible = "arm,pl031", "arm,primecell";
> +                       reg = <0x0 0xf8004000 0x0 0x1000>;
> +                       interrupts = <0 8 4>;
> +                       clocks = <&ao_ctrl HI6220_RTC1_PCLK>;
> +                       clock-names = "apb_pclk";
> +               };
> +
>
> Would you please append that into the patch?

Sure. I also noticed the node offset for rtc0 doesn't match the
register, so I corrected it as well.

thanks
-john