Re: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it

From: Stefan Wahren
Date: Thu Jun 02 2016 - 15:09:59 EST


Hi Eric,

> Eric Anholt <eric@xxxxxxxxxx> hat am 2. Juni 2016 um 20:18 geschrieben:
>
>
> Stefan Wahren <stefan.wahren@xxxxxxxx> writes:
>
> > Hi Gerd,
> >
> > Am 01.06.2016 um 23:43 schrieb Gerd Hoffmann:
> >> From: Eric Anholt <eric@xxxxxxxxxx>
> >>
> >> With this we can get wifi (brcmfmac) to probe. Without it we're stuck
> >> with timeouts from sdio.c when it tries to set the bus width to 4.
> >
> > adding a new MMC driver to fix a wifi issue is really weird.
> >
> > Beside that there are already two MMC drivers (sdhci-bcm2835.c and
> > sdhci-iproc.c) in the Kernel which are compatible to BCM2835. Why should
> > we add two new ones?
>
> Despite the fact that this is my commit, I don't think it should be
> merged. We should figure out why sdhci-iproc.c isn't working, instead.

so it doesn't work with sdhci-bcm2835 on RPi 3, too?

I plan to send a patch series to remove sdhci-bcm2835.

Stefan