Re: [PATCH v2 2/7] DT: phy.txt: Add mdio-integrated-mux property
From: Andrew Lunn
Date: Thu Jun 02 2016 - 20:46:49 EST
On Thu, Jun 02, 2016 at 06:27:03PM -0500, Rob Herring wrote:
> On Tue, May 31, 2016 at 07:06:36PM +0530, Pramod Kumar wrote:
> > This property is used by integrated MDIO multiplexer
> > which has bus selection and mdio transaction generation logic,
> > integrated inside.
> >
> > Signed-off-by: Pramod Kumar <pramod.kumar@xxxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/net/mdio-mux.txt | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/mdio-mux.txt b/Documentation/devicetree/bindings/net/mdio-mux.txt
> > index 491f5bd..b5ad83e 100644
> > --- a/Documentation/devicetree/bindings/net/mdio-mux.txt
> > +++ b/Documentation/devicetree/bindings/net/mdio-mux.txt
> > @@ -5,13 +5,20 @@ numbered uniquely in a device dependent manner. The nodes for an MDIO
> > bus multiplexer/switch will have one child node for each child bus.
> >
> > Required properties:
> > -- mdio-parent-bus : phandle to the parent MDIO bus.
> > - #address-cells = <1>;
> > - #size-cells = <0>;
> >
> > Optional properties:
> > +- mdio-parent-bus : phandle to the parent MDIO bus. Should be used
> > + if parent mdio bus is not part of multiplexer.
>
> You don't appear to be using this. When would you?
He is moving it to optional. The mdio-mux-mmio and mdio-mux-gpio do
however use it, which follow this binding.
Andrew