Re: [PATCH] Dyna-Image AL3320A update, add AL3010 driver

From: Lars-Peter Clausen
Date: Fri Jun 03 2016 - 04:20:49 EST


On 06/03/2016 06:02 AM, Rocky Hsiao wrote:
> 1. Change al3320a.c to match light sensor test flow.
> 2. Add al3010.c to add new device AL3010.
> original file copy from al3320a.c

Hi,

Thanks for the patch. In addition to what Daniel said, for upstream patch
submissions it is important to have proper commit messages explaining what
is done, why it is done and how it is done. The commit messages should
follow the general style of the subsystem you are sending the patch to. E.g.
in the IIO case this means that the subject line should start with "iio: ...".

http://chris.beams.io/posts/git-commit/ is a very good document that
describes how to create a good commit message and I recommend reading it.

- Lars