Re: [PATCH] of: irq: don't return 0 from of_irq_get()

From: Rob Herring
Date: Fri Jun 03 2016 - 08:14:39 EST

On Sun, May 29, 2016 at 12:53:08AM +0300, Sergei Shtylyov wrote:
> of_irq_get() returns 0 iff irq_create_of_mapping() call fails. Returning
> both error code and 0 on failure is a sign of a misdesigned API. Return
> -ENXIO instead like one of the callers, platform_get_irq(), does; fix up
> the kernel-doc as well...
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>

So I think this is done this way because of the variation in NO_IRQ
definition across architectures. But then again, of_irq_get is
relatively new.