RE: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

From: Mario_Limonciello
Date: Fri Jun 03 2016 - 11:10:39 EST


> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Thursday, June 2, 2016 9:02 PM
> To: Limonciello, Mario <Mario_Limonciello@xxxxxxxx>
> Cc: hayeswang@xxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; pali.rohar@xxxxxxxxx;
> anthony.wong@xxxxxxxxxxxxx
> Subject: Re: [PATCH v2] r8152: Add support for setting MAC to system's
> Auxiliary MAC address
>
> On Thu, Jun 02, 2016 at 06:32:42PM +0000, Mario_Limonciello@xxxxxxxx
> wrote:
> > > And you want to check this for all Dell devices? Please be model
> > > specific, I doubt a bunch of Dell servers wants to run this code...
> > >
> >
> > Tracking model specific is really going to turn into a giant list never ending
> list.
> > To drill down more specifically, I can match on chassis too.
>
> Yes, as this is a vendor/platform-specific "quirk", you will have to
> update it for each and every individual device you want it enabled as it
> is so different from what all other drivers do.
>
> thanks,
>
> greg k-h

After finding out that there is a characteristic specific to Realtek chip in this USB
device, I think it would be best to only run the \\_SB.AMAC lookup when this
specific USB device is connected.

Realtek is not maintaining a whitelist of systems in their driver for the other OS,
they approach it from the other end and only lookup auxiliary MAC if the right
device is plugged in.