Re: [PATCH 0/4] *** rtl8188eu: Replace semaphores with mutexes or completions ***

From: Arnd Bergmann
Date: Sat Jun 04 2016 - 06:44:01 EST


On Friday, June 3, 2016 3:28:59 PM CEST Binoy Jayan wrote:
>
> These are a set of patches which removes semaphores from:
>
> drivers/staging/rtl8188eu
>
> These are part of a bigger effort to eliminate all semaphores
> from the linux kernel.
>
> They build correctly (individually and as a whole).
> NB: I have not tested this as I do not have the following hardware:
>
> "Realtek RTL8188EU Wireless LAN NIC driver"
>
>

The patches all look good to me. Patch three again could use some
information describing that it replaces an interruptible semaphore
with an uninterruptible mutex, fixing a bug in the process.

BTW, there is no need to list the dependencies in each patch
when posting a series, as the default assumption is that they
need to be applied in sequence.

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>