Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix

[Jeff Layton]

On Sun, 2016-06-05 at 11:23 +0200, Geert Uytterhoeven wrote:
> On 32-bit:
> 
> ÂÂÂÂfs/nfsd/blocklayout.c: In function ânfsd4_block_get_device_info_scsiâ:
> ÂÂÂÂfs/nfsd/blocklayout.c:337: warning: integer constant is too large for âlongâ type
> ÂÂÂÂfs/nfsd/blocklayout.c:344: warning: integer constant is too large for âlongâ type
> ÂÂÂÂfs/nfsd/blocklayout.c: In function ânfsd4_scsi_fence_clientâ:
> ÂÂÂÂfs/nfsd/blocklayout.c:385: warning: integer constant is too large for âlongâ type
> 
> Add the missing "ULL" postfix to 64-bit constant NFSD_MDS_PR_KEY to fix
> this.
> 
> Fixes: f99d4fbdae6765d0 ("nfsd: add SCSI layout support")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> ---
> v2:
> Â - Add Reviewed-by.
> 
> Despite Bruce's "Thanks, applying for 4.6.--b." on 2016-03-29, this
> still hasn't made it into next-20160603.
> ---
> Âfs/nfsd/blocklayout.c | 2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/blocklayout.c b/fs/nfsd/blocklayout.c
> index e55b5242614da7a9..31f3df193bdbb47b 100644
> --- a/fs/nfsd/blocklayout.c
> +++ b/fs/nfsd/blocklayout.c
> @@ -290,7 +290,7 @@ out_free_buf:
> Â	return error;
> Â}
> Â
> -#define NFSD_MDS_PR_KEY		0x0100000000000000
> +#define NFSD_MDS_PR_KEY		0x0100000000000000ULL
> Â
> Â/*
> Â * We use the client ID as a unique key for the reservations.

Thanks!

Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxxxxxxx>