Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning

From: Andy Shevchenko
Date: Sun Jun 05 2016 - 10:21:04 EST


Andy Shevchenko worte:
> On Sat, 2016-06-04 at 09:16 -0400, George Spelvin wrote:
> Which I against of. Please, use normal hex_to_bin() calls here.
>
> Compiler will inline it anyway, but at least will not do second check
> for nothing.

Um... huh? Neither hex_to_bin() nor hex2bin() are inline functions.
They're declared as extern in <linux/kernel.h> and defined in
lib/hexdump.c.

One call is smaller than two calls, which is why I did that.

It's also faster, as hex_to_bin() *is* inlined within hex2bin()
(if you compile with -O).

Is your request based on a false premise?