Re: [PATCH v3 5/6] watchdog: pretimeout: add panic pretimeout governor

From: Wolfram Sang
Date: Wed Jun 08 2016 - 03:08:17 EST



> +static void pretimeout_panic(struct watchdog_device *wdd)
> +{
> + panic("panic on watchdog pretimeout event\n");
> +}

And here we have the same redundant message again ("panic on") :( Did
you look at my patches at all? To me, it looks like you didn't or you
are intentionally trying to leave my changes out. I don't think they
were all bad. In the previous patch in watchdog_notify_pretimeout() you
used the shortened message BTW.

Attachment: signature.asc
Description: PGP signature