Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs

[Ingo Molnar]

* H. Peter Anvin <hpa@xxxxxxxxx> wrote:

> On 06/08/16 01:28, Ingo Molnar wrote:
> > 
> > It does matter:
> > 
> >  In file included from arch/x86/kernel/cpu/common.c:21:0:
> >  ./arch/x86/include/asm/archrandom.h:95:20: error: redefinition of âarch_get_random_longâ
> >  static inline bool arch_get_random_long(unsigned long *v)
> >  In file included from ./arch/x86/include/asm/stackprotector.h:43:0,
> >  include/linux/random.h:98:20: note: previous definition of âarch_get_random_longâ was here
> > 
> 
> Actually this is an indication of a major bug, quite possibly
> pre-existing; we somehow are trying to include both the stub and the
> non-stub version of arch_get_random_long(), which is an obvious no-no.

Yeah.

> I will look at it in the morning (02:00 here.)

Sure, take your time! I've rewinded x86/asm to 08dd8cd06ed9 for the time being.

Thanks,

	Ingo