Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs

[H. Peter Anvin]

On 06/08/16 02:01, Ingo Molnar wrote:
> 
> That's a divergence with an underlying reason - but not harmonizing the return 
> code is an unforced error AFAICS and can be fixed.
>

Perhaps.  It is also no real question that "bool" is the right return
type for a single bit.  Changing that in all architectures at one time
is a major undertaking, however, and it seems to me that it would be
better to leave that to the respective architecture maintainers.

Perhaps I'm wrong, but I'd really like to avoid the upcasting to "int"
which isn't needed, because in my testing I find that it definitely
encourages gcc to generate poor code.

	-hpa