RE: [PATCH] x86/microcode/intel: Quieten down microcode updates on large systems

From: Elliott, Robert (Persistent Memory)
Date: Thu Jun 09 2016 - 00:34:43 EST




> -----Original Message-----
> From: linux-kernel-owner@xxxxxxxxxxxxxxx [mailto:linux-kernel-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Andi Kleen
> Sent: Tuesday, May 31, 2016 4:23 PM
> To: x86@xxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Andi Kleen <ak@xxxxxxxxxxxxxxx>
> Subject: [PATCH] x86/microcode/intel: Quieten down microcode updates
> on large systems
...
> diff --git a/arch/x86/kernel/cpu/microcode/intel.c
> @@ -808,8 +809,14 @@ static int collect_cpu_info(int cpu_num, struct
> cpu_signature *csig)
> }
>
> csig->rev = c->microcode;
> - pr_info("CPU%d sig=0x%x, pf=0x%x, revision=0x%x\n",
> - cpu_num, csig->sig, csig->pf, csig->rev);
> +
> + /* No extra locking on prev, races are harmless. */
> + if (csig->sig != prev.sig || csig->pf != prev.pf ||
> + csig->rev != prev.rev) {
> + pr_info("CPU sig=0x%x, pf=0x%x, revision=0x%x\n",
> + csig->sig, csig->pf, csig->rev);
> + prev = *csig;
> + }
...
> - pr_info("CPU%d updated to revision 0x%x, date = %04x-%02x-
> %02x\n",
> - cpu, val[1],
> - mc->hdr.date & 0xffff,
> - mc->hdr.date >> 24,
> - (mc->hdr.date >> 16) & 0xff);
> + if (val[1] != prev_rev) {
> + pr_info("CPU updated to revision 0x%x, date = %04x-%02x-
> %02x\n",

"CPU(s)" would help convey that the messages now apply to one or
more CPUs.