Re: [PATCH] Add .set_antenna callback in ath6kl driver to fix wireless core warns

[Johannes Berg]

On Thu, 2016-06-09 at 11:06 +0530, Prasun Maiti wrote:
> Since add more warnings for inconsistent ops in cfg80211, the
> wireless
> core warns if a driver implements a cfg80211 callback but doesn't
> implements the inverse operation. The ath6kl driver implements a
> cfg80211
> .get_antenna operation handler but doesn't have the inverse
> .set_antenna
> callback. So, it makes warning.
> 
> To remove this warning, add .set_antenna callback in ath6kl driver
> which
> is unimplemented.
> 
> Signed-off-by: Prasun Maiti <prasunmaiti87@xxxxxxxxx>
> ---
> Âdrivers/net/wireless/ath/ath6kl/cfg80211.c | 11 +++++++++++
> Â1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c
> b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> index 4e11ba0..e638296 100644
> --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
> +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> @@ -3231,6 +3231,16 @@ static int ath6kl_mgmt_tx(struct wiphy *wiphy,
> struct wireless_dev *wdev,
> Â					wait, buf, len, no_cck);
> Â}
> Â
> +static int ath6kl_set_antenna(struct wiphy *wiphy,
> +				u32 tx_ant, u32 rx_ant)
> +{
> +	/*
> +	Â* Note: This callback should be implement when firmware
> support this
> +	Â* command.
> +	Â*/
> +	return 0;
> +}
> 
Seriously, this makes no sense at all. Just submit a patch to remove
the warning.

johannes