Re: [PATCH v9 11/14] usb: otg: use dev_dbg() instead of VDBG()

[Roger Quadros]

On 08/06/16 18:10, Joe Perches wrote:
> On Wed, 2016-06-08 at 12:03 +0300, Roger Quadros wrote:
>> Now that we have a device reference in struct usb_otg
>> let's use dev_dbg() for debug messages.
> 
> dev_vdbg vs dev_dbg
> 
> The patch subject and commit message don't match the code changes.

Indeed. Will fix it. Thanks.

> 
>> diff --git a/drivers/usb/common/usb-otg-fsm.c b/drivers/usb/common/usb-otg-fsm.c
> []
>> @@ -44,8 +37,9 @@ static int otg_set_protocol(struct otg_fsm *fsm, int protocol)
>>  	int ret = 0;
>>  
>>  	if (fsm->protocol != protocol) {
>> -		VDBG("Changing role fsm->protocol= %d; new protocol= %d\n",
>> -			fsm->protocol, protocol);
>> +		dev_vdbg(otg->dev,
>> +			 "Changing role fsm->protocol= %d; new protocol= %d\n",
>> +			 fsm->protocol, protocol);
> 
> etc...
> 

--
cheers,
-roger