RE: [PATCH v9 13/14] usb: gadget: udc: adapt to OTG core

From: Yoshihiro Shimoda
Date: Thu Jun 09 2016 - 06:49:26 EST


Hi Roger,

> From: Roger Quadros
> Sent: Wednesday, June 08, 2016 6:04 PM
>
> The OTG state machine needs a mechanism to start and
> stop the gadget controller as well as connect/disconnect
> from the bus. Add usb_gadget_start(), usb_gadget_stop()
> and usb_gadget_connect_control().
>
> Introduce usb_otg_add_gadget_udc() to allow controller drivers
> to register a gadget controller that is part of an OTG instance.
>
> Register with OTG core when UDC is added in usb_add_gadget_udc_release()
> and unregister on usb_del_gadget_udc().
>
> Notify the OTG core when gadget function driver is available on
> udc_bind_to_driver() and when it is removed in usb_gadget_remove_driver().
>
> We need to unlock the usb_lock mutex before calling
> usb_otg_register_gadget() else it will cause a circular
> locking dependency.
>
> Ignore softconnect sysfs control when we're in OTG
> mode as OTG FSM should care of gadget softconnect using
> the b_bus_req mechanism.
>
> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
> ---
> drivers/usb/gadget/udc/udc-core.c | 202 ++++++++++++++++++++++++++++++++++++--
> include/linux/usb/gadget.h | 4 +
> 2 files changed, 196 insertions(+), 10 deletions(-)

I tried to apply this patch on the Felipe's usb.git / testing/next branch,
but I couldn't apply because the udc-core.c was renamed to core.c.
https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=a22b539c7082b6a3046b3a9cebb356a047a2d81d

I guess this patch needs rebase for that.

Best regards,
Yoshihiro Shimoda