Re: [PATCH 2/2] ARM: dts: TS-4800: add CAN support

[Shawn Guo]

On Tue, May 17, 2016 at 04:16:30PM -0400, Damien Riegel wrote:
> This enables support for the CAN controller located in the FPGA.
> 
> Signed-off-by: Damien Riegel <damien.riegel@xxxxxxxxxxxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/imx51-ts4800.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
> index 2c89988..41be82e 100644
> --- a/arch/arm/boot/dts/imx51-ts4800.dts
> +++ b/arch/arm/boot/dts/imx51-ts4800.dts
> @@ -149,6 +149,16 @@
>  		#size-cells = <1>;
>  		ranges = <0 0 0 0x1d000>;
>  
> +		can@0,1a000 {
> +			compatible = "technologic,sja1000";
> +			reg = <0x1a000 0x00000100>;
> +			interrupt-parent = <&fpga_irqc>;
> +			interrupts = <1>;
> +			reg-io-width = <2>;
> +			nxp,tx-output-config = <0x06>;
> +			nxp,external-clock-frequency = <24000000>;
> +		};
> +

For nodes under bus node with unit-address (or 'reg' property), it makes
more sense to sort the nodes in order of unit-address.

Shawn

>  		fpga_irqc: fpga_irqc@0,15000 {
>  			compatible = "technologic,ts4800-irqc";
>  			reg = <0x15000 0x1000>;
> -- 
> 2.5.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel