Re: [PATCH 8/8] dmaengine: Remove site specific OOM error messages on kzalloc

From: Lee Jones
Date: Thu Jun 09 2016 - 11:30:11 EST


On Wed, 08 Jun 2016, Linus Walleij wrote:

> On Tue, Jun 7, 2016 at 7:38 PM, Peter Griffin <peter.griffin@xxxxxxxxxx> wrote:
>
> > If kzalloc() fails it will issue it's own error message including
> > a dump_stack(). So remove the site specific error messages.
> >
> > Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
>
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> A few subsystems may use a cleanup like this...
> I wonder how many unnecessary prints I've introduced
> myself :P

Wolfram did some analysis on this a while back. IIRC he also
presented on his findings at ELC(?).

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog