Re: [PATCH 2/3] i2c: octeon: Add retry logic after receiving STAT_RXADDR_NAK
From: Wolfram Sang
Date: Thu Jun 09 2016 - 16:12:07 EST
On Wed, Jun 08, 2016 at 08:51:18AM +0200, Jan Glauber wrote:
> The controller specification states that when receiving STAT_RXADDR_NAK
> the START should be sent again. Retry several times before finally
> failing with -ENXIO.
>
> Without this change the IPMI SSIF driver fails executing several commands
> like 'ipmitool fru' on ThunderX.
Huh? Looks wrong to me. I'd say the client driver needs to retry. Only
that one knows if retrying is appropriate or a waste of time.
Attachment:
signature.asc
Description: PGP signature