Re: [PATCH] m32r: add __ucmpdi2 to fix build failure

[Andrew Morton]

On Thu,  9 Jun 2016 22:53:33 +0100 Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote:

> We are having build failure with m32r and the error message being:
> ERROR: "__ucmpdi2" [lib/842/842_decompress.ko] undefined!
> ERROR: "__ucmpdi2" [fs/btrfs/btrfs.ko] undefined!
> ERROR: "__ucmpdi2" [drivers/scsi/sd_mod.ko] undefined!
> ERROR: "__ucmpdi2" [drivers/media/i2c/adv7842.ko] undefined!
> ERROR: "__ucmpdi2" [drivers/md/bcache/bcache.ko] undefined!
> ERROR: "__ucmpdi2" [drivers/iio/imu/inv_mpu6050/inv-mpu6050.ko] undefined!
> 
> __ucmpdi2 is introduced to m32r architecture taking example from other
> architectures like h8300, microblaze, mips.
> 
> --- a/arch/m32r/kernel/m32r_ksyms.c
> +++ b/arch/m32r/kernel/m32r_ksyms.c
> @@ -41,6 +41,9 @@ EXPORT_SYMBOL(cpu_data);
>  EXPORT_SYMBOL(smp_flush_tlb_page);
>  #endif
>  
> +extern int __ucmpdi2(unsigned long long a, unsigned long long b);
> +EXPORT_SYMBOL(__ucmpdi2);
> +

This would be neater.  Does it work?


From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: m32r-add-__ucmpdi2-to-fix-build-failure-fix

avoid extern declaration in .c file

Cc: Sudip Mukherjee <sudip.mukherjee@xxxxxxxxxxxxxxx>
Cc: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

--- a/arch/m32r/kernel/m32r_ksyms.c~m32r-add-__ucmpdi2-to-fix-build-failure-fix
+++ a/arch/m32r/kernel/m32r_ksyms.c
@@ -41,7 +41,6 @@ EXPORT_SYMBOL(cpu_data);
 EXPORT_SYMBOL(smp_flush_tlb_page);
 #endif
 
-extern int __ucmpdi2(unsigned long long a, unsigned long long b);
 EXPORT_SYMBOL(__ucmpdi2);
 
 /* compiler generated symbol */
--- a/arch/m32r/lib/libgcc.h~m32r-add-__ucmpdi2-to-fix-build-failure-fix
+++ a/arch/m32r/lib/libgcc.h
@@ -22,3 +22,4 @@ typedef union {
 
 #endif /* __ASM_LIBGCC_H */
 
+extern int __ucmpdi2(unsigned long long a, unsigned long long b);