RE: [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma mode
From: Appana Durga Kedareswara Rao
Date: Mon Jun 13 2016 - 01:38:07 EST
Hi Vinod,
> On Thu, Jun 09, 2016 at 11:32:12AM +0530, Kedareswara rao Appana wrote:
> > This patch fixes the below compilation warining.
> > drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic':
> > drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be
> > used uninitialized in this function [-Wmaybe-uninitialized]
> > segment->hw.control |= XILINX_DMA_BD_SOP;
> >
> > The start of packet (SOP) should be set to the first segment in the
> > desc chain not for the last segment of the desc chain.
>
> I have applied this after adding Reported by from SFR.
Sorry will fix it next time on wards....
>
> You should always give credit to folks who report issues.
Sure will fix next time onwards...
Thanks,
Kedar.