Re: [PATCH] dma: remove bad_dma_ops to fix build fail
From: Sudip Mukherjee
Date: Mon Jun 13 2016 - 06:51:22 EST
On Mon, Jun 13, 2016 at 10:29:34AM +0100, Mark Brown wrote:
> On Mon, Jun 13, 2016 at 08:41:12AM +0100, Sudip Mukherjee wrote:
> > On Sun, Jun 12, 2016 at 02:32:24PM -0700, Jerry Snitselaar wrote:
>
> > > config SND_SOC_CYGNUS
> > > tristate "SoC platform audio for Broadcom Cygnus chips"
> > > depends on ARCH_BCM_CYGNUS || COMPILE_TEST
> > > + depends on HAS_DMA
> > > help
> > > Say Y if you want to add support for ASoC audio on Broadcom
> > > Cygnus chips (bcm958300, bcm958305, bcm911360)
>
> > well, I have been doing the exact same thing for all the drivers that was
> > failing to build but in my last patch Mark suggested to have stub
> > implementation in the arch [1]. So while looking for that I noticed
> > bad_dma_ops is not defined by anyone. So what will you suggest?
>
> Right, we've got a couple of obscure architectures with no DMA support
> which are leading to a constant stream of patches like this that are
> being triggered by compile coverage stuff. In situations like this we
> very often provide stubs rather than having to handle this in lots of
> different places in the code.
Ok, I will do that. But I am seeing arch/m32r/include/asm/m32102.h is
defining the DMA Controller registers and also a MAX_DMA_ADDRESS is
defined in dma.h. Doesn't that mean that this arch is capable of DMA?
Regards
Sudip