Re: [PATCH 1/3 v2] drm/arcpgu: Make ARC PGU usable on simulation platforms

From: Daniel Vetter
Date: Mon Jun 13 2016 - 10:09:39 EST


On Mon, Jun 13, 2016 at 12:47:33PM +0000, Alexey Brodkin wrote:
> Hi Daniel,
>
> On Fri, 2016-06-10 at 17:29 +0300, Alexey Brodkin wrote:
> > From: Ruud Derwig <rderwig@xxxxxxxxxxxx>
> >
> > In case of simulation there's no real encoder/transmitter device
> > because in the model's virtual LCD  we're rendering whatever
> > appears in frame-buffer memory.
> >
> > Signed-off-by: Ruud Derwig <rderwig@xxxxxxxxxxxx>
> > Signed-off-by: Alexey Brodkin <abrodkin@xxxxxxxxxxxx>
> > ---
> >
> > Changes v1 -> v2:
> >  * Got rid of dummy arcpgu_drm_encoder_helper_funcs and now rely on default
> >    best encoder
>
> If that version looks good to you could you please provide your Ack?

I just do drive-by comments on driver submissions, review/merge rules are
up to each driver maintainer mostly. But for the warm and fuzzy feeling
I'm happy to ack ;-)

Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch