Re: [PATCH v3] iio: stx104: Add GPIO support for the Apex Embedded Systems STX104

From: Linus Walleij
Date: Tue Jun 14 2016 - 02:53:55 EST


On Mon, Jun 13, 2016 at 3:06 PM, William Breathitt Gray
<vilhelm.gray@xxxxxxxxx> wrote:

> The Apex Embedded Systems STX104 device features eight lines of digital
> I/O (four digital inputs and four digital outputs). This patch adds GPIO
> support for these eight lines of digital I/O via GPIOLIB.
>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Alexandre Courbot <gnurou@xxxxxxxxx>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx>
> ---
> Changes in v3:
> - Revert v2 change; any arch should be able to select GPIOLIB
> - Return -EINVAL when attempting to set a GPIO to a direction it
> cannot be
> - Call stx104_gpio_set to have an initial value when setting a GPIO to
> output direction

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij