Re: [PATCH 6/6] MIPS: BMIPS: Add device tree example for BCM6362

[Jonas Gorski]

Hi,

On 13 June 2016 at 09:38, Ãlvaro FernÃndez Rojas <noltari@xxxxxxxxx> wrote:
> This adds a device tree example for SFR NeufBox 6.
>
> Signed-off-by: Ãlvaro FernÃndez Rojas <noltari@xxxxxxxxx>
> ---
>  arch/mips/bmips/Kconfig                    |   4 +
>  arch/mips/boot/dts/brcm/Makefile           |   2 +
>  arch/mips/boot/dts/brcm/bcm6362.dtsi       | 134 +++++++++++++++++++++++++++++
>  arch/mips/boot/dts/brcm/bcm96362nb6ser.dts |  22 +++++
>  4 files changed, 162 insertions(+)
>  create mode 100644 arch/mips/boot/dts/brcm/bcm6362.dtsi
>  create mode 100644 arch/mips/boot/dts/brcm/bcm96362nb6ser.dts
>
> diff --git a/arch/mips/bmips/Kconfig b/arch/mips/bmips/Kconfig
> index 5b0ad8c..43da496 100644
> --- a/arch/mips/bmips/Kconfig
> +++ b/arch/mips/bmips/Kconfig
> @@ -33,6 +33,10 @@ config DT_BCM96358NB4SER
>         bool "BCM96358NB4SER"
>         select BUILTIN_DTB
>
> +config DT_BCM96362NB6SER
> +       bool "BCM96362NB6SER"

DT_SFR_NEUFBOX6_SERCOMM
       bool "SFR Neufbox 6 (Sercomm)"

maybe?

> +       select BUILTIN_DTB
> +
>  config DT_BCM96368MVWG
>         bool "BCM96368MVWG"
>         select BUILTIN_DTB
> diff --git a/arch/mips/boot/dts/brcm/Makefile b/arch/mips/boot/dts/brcm/Makefile
> index c553b95..161e54b 100644
> --- a/arch/mips/boot/dts/brcm/Makefile
> +++ b/arch/mips/boot/dts/brcm/Makefile
> @@ -3,6 +3,7 @@ dtb-$(CONFIG_DT_BCM93384WVG)            += bcm93384wvg.dtb
>  dtb-$(CONFIG_DT_BCM93384WVG_VIPER)     += bcm93384wvg_viper.dtb
>  dtb-$(CONFIG_DT_BCM963268VR3032U)      += bcm963268vr3032u.dtb
>  dtb-$(CONFIG_DT_BCM96358NB4SER)                += bcm96358nb4ser.dtb
> +dtb-$(CONFIG_DT_BCM96362NB6SER)                += bcm96362nb6ser.dtb

Similar here.

>  dtb-$(CONFIG_DT_BCM96368MVWG)          += bcm96368mvwg.dtb
>  dtb-$(CONFIG_DT_BCM9EJTAGPRB)          += bcm9ejtagprb.dtb
>  dtb-$(CONFIG_DT_BCM97125CBMB)          += bcm97125cbmb.dtb
> @@ -20,6 +21,7 @@ dtb-$(CONFIG_DT_NONE)                 += \
>                                                 bcm93384wvg_viper.dtb   \
>                                                 bcm963268vr3032u.dtb    \
>                                                 bcm96358nb4ser.dtb      \
> +                                               bcm96362nb6ser.dtb      \
>                                                 bcm96368mvwg.dtb        \
>                                                 bcm9ejtagprb.dtb        \
>                                                 bcm97125cbmb.dtb        \

(snip)

> diff --git a/arch/mips/boot/dts/brcm/bcm96362nb6ser.dts b/arch/mips/boot/dts/brcm/bcm96362nb6ser.dts
> new file mode 100644
> index 0000000..a470230
> --- /dev/null
> +++ b/arch/mips/boot/dts/brcm/bcm96362nb6ser.dts

Similar here.

> @@ -0,0 +1,22 @@
> +/dts-v1/;
> +
> +/include/ "bcm6362.dtsi"
> +
> +/ {
> +       compatible = "sfr,nb6-ser", "brcm,bcm6362";

I don't see the sfr vendor prefix documented (at least not in
4.7-rc2). If it is already in -next, then disregard that comment.


> +       model = "SFT NeufBox 6 (Sercomm)";

SFT? Not SFR? ;p



Regards
Jonas