Re: [PATCH v1 1/1] x86/platform/intel-mid: Add Power Management Unit driver

[Ingo Molnar]

* Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> On Tue, 2016-06-14 at 12:43 +0200, Ingo Molnar wrote:
> > * Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > 
> > > Add Power Management Unit driver to handle power states of South
> > > Complex
> > > devices on Intel Tangier. In the future it might be expanded to
> > > cover North
> > > Complex devices as well.
> > > 
> > > With this driver the power state of the host controllers such as
> > > SPI, I2C,
> > > UART, eMMC, and DMA would be managed.
> > > 
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > ---
> > > Âarch/x86/include/asm/intel-mid.hÂÂÂÂÂ|ÂÂÂ8 +
> > > Âarch/x86/pci/intel_mid_pci.cÂÂÂÂÂÂÂÂÂ|ÂÂ35 +++-
> > > Âarch/x86/platform/intel-mid/Makefile |ÂÂÂ2 +-
> > > Âarch/x86/platform/intel-mid/pmu.cÂÂÂÂ| 392
> > > +++++++++++++++++++++++++++++++++++
> > > Âdrivers/pci/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ3 +
> > > Âdrivers/pci/pci-mid.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ77 +++++++
> > > Â6 files changed, 515 insertions(+), 2 deletions(-)
> > > Âcreate mode 100644 arch/x86/platform/intel-mid/pmu.c
> > > Âcreate mode 100644 drivers/pci/pci-mid.c
> > 
> > So this collides with perf's 'PMU' naming massively. Can we pick
> > another nameÂ
> > before hillarious kernel-wide confusion spreads?
> > 
> > how about intel/mid/pm.c plus renaming all the pmu* internal names to
> > pm*?
> > 
> > We could call it 'power management interface', and in a single line
> > mention thatÂ
> > this is also a 'Power Management Unit' in Intel-speak?
> 
> In the TRM it's called Power Management Unit, though once or twice in some 
> documents as Power Management Controller. I actually woudn't like to use PMC 
> abbreviation to not be confused with pmc_atom.c and many other variation of 
> existing PMC drivers of other Intel platforms.
> 
> PM* as a prefix might be too short to conflict with Power Management framework 
> in the kernel. P-Unit (punit*) is existing part in SoC which will have its own 
> driver in the future, so, can't use it either.
> 
> pwr*, pwrmu*, scpmu* (as of South Complex Power Management Unit) â one of them?

'pwr' certainly sounds good to me! PWMU perhaps?

Thanks,

	Ingo