Re: [PATCH 2/5] export.h: use __is_defined() to check if __KSYM_* is defined

From: Nicolas Pitre
Date: Tue Jun 14 2016 - 13:10:56 EST


On Tue, 14 Jun 2016, Masahiro Yamada wrote:

> Here the need is for a macro that checks whether the given symbol is
> defined or not, which has nothing to do with config.
>
> The new macro __is_defined() is a better fit for this case.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

Acked-by: Nicolas Pitre <nico@xxxxxxxxxx>

> ---
>
> include/linux/export.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/export.h b/include/linux/export.h
> index 2f9ccbe..c565f87 100644
> --- a/include/linux/export.h
> +++ b/include/linux/export.h
> @@ -82,7 +82,7 @@ extern struct module __this_module;
> #include <generated/autoksyms.h>
>
> #define __EXPORT_SYMBOL(sym, sec) \
> - __cond_export_sym(sym, sec, config_enabled(__KSYM_##sym))
> + __cond_export_sym(sym, sec, __is_defined(__KSYM_##sym))
> #define __cond_export_sym(sym, sec, conf) \
> ___cond_export_sym(sym, sec, conf)
> #define ___cond_export_sym(sym, sec, enabled) \
> --
> 1.9.1
>
>