Re: [PATCH] firmware: qcom: scm: Expose PAS command 10 as reset-controller

[Stephen Boyd]

On 06/10, Bjorn Andersson wrote:
> PAS command 10 is used to assert and deassert the MSS reset via
> TrustZone, expose this as a reset-controller to follow the non-secure
> case where GCC exposes this control.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/firmware/qcom,scm.txt      |  6 ++++
>  drivers/firmware/qcom_scm-32.c                     | 13 +++++++++
>  drivers/firmware/qcom_scm-64.c                     | 17 +++++++++++
>  drivers/firmware/qcom_scm.c                        | 34 ++++++++++++++++++++++
>  drivers/firmware/qcom_scm.h                        |  2 ++

We should add some sort of select for the reset controller
config in SCM?

> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 79bb0b00577e..b0119535c0fb 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -21,6 +21,7 @@
>  
> +
> +static struct reset_control_ops qcom_scm_pas_reset_ops = {

const?

> +	.assert = qcom_scm_pas_reset_assert,
> +	.deassert = qcom_scm_pas_reset_deassert,
> +};
> +
>  static int qcom_scm_probe(struct platform_device *pdev)
>  {
>  	struct qcom_scm *scm;

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project