Re: [PATCH] KVM: SVM: compile out AVIC if !CONFIG_X86_LOCAL_APIC
From: Suravee Suthikulanit
Date: Tue Jun 14 2016 - 14:35:49 EST
Hi Paolo,
On 6/14/2016 11:40 AM, Paolo Bonzini wrote:
AVIC needs __default_cpu_present_to_apicid. Stub out all functions
that use it, and disable the module parameter, if Linux is
compiled without local APIC support.
I think you are right that we should disable AVIC #ifndef
CONFIG_X86_LOCAL_APIC. However, do you think we should just use
default_cpu_present_to_apicid() instead of the
__default_cpu_present_to_apicid()? This way, we can avoid having #ifdef
CONFIG_X86_LOCAL_APIC in multiple places.
As for disabling AVIC, I think we can also do:
if (!IS_ENABLED(CONFIG_X86_LOCAL_APIC))
avic = false;
What do you think?
Thanks,
Suravee