Re: [PATCH v2 net-next v2 08/12] net: dsa: mv88e6xxx: read switch ID from info

[Vivien Didelot]

Hi,

Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> writes:

>> -	id = mv88e6xxx_reg_read(ps, REG_PORT(0), PORT_SWITCH_ID);
>> +	of_id = of_match_node(mv88e6xxx_of_id_table, np);
>
>     You could use of_device_get_match_data() here.
>
>> +	if (!of_id)
>> +		return -EINVAL;
>> +
>> +	info = (const struct mv88e6xxx_info *)of_id->data;
>
>     Pointer casts from 'void *' are automatic.

I applied your comments and also squashed patches 7 and 8 together.
I'll respin a v3 soon unless there are other comments.

Thanks,

        Vivien