Re: [PATCH v3 3/3] LSM: Add context interface for proc attr

From: Kees Cook
Date: Tue Jun 14 2016 - 17:07:35 EST


On Tue, Jun 14, 2016 at 1:19 PM, Casey Schaufler <casey@xxxxxxxxxxxxxxxx> wrote:
> On 6/14/2016 11:57 AM, Kees Cook wrote:

>> it's okay.) Also, should lsm == NULL be checked early and
>> rejected/skipped so the lsm != NULL test isn't needed in both loops?
>
> Ah, you miss the nuance of the code. NULL is an acceptance condition,
> not a rejection as it would be in most cases.

Ah! Yes, got it now. Thanks!

-Kees

--
Kees Cook
Chrome OS & Brillo Security